Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug sessions failing to execute #11263

Closed
colin-grant-work opened this issue Jun 6, 2022 · 3 comments · Fixed by #11268
Closed

Debug sessions failing to execute #11263

colin-grant-work opened this issue Jun 6, 2022 · 3 comments · Fixed by #11268
Labels
bug bugs found in the application critical critical bugs / problems debug issues that related to debug functionality

Comments

@colin-grant-work
Copy link
Contributor

Bug Description:

It appears that starting debug sessions is failing.

Steps to Reproduce:

  1. Open a .spec.ts file in the repo and try the Run Mocha Tests debug configuration.
  2. Observe that the Threads widget shows the session, but no breakpoints are hit, no variables are shown, etc.
  3. Try a dynamic Node configuration like 'Run current file'.
  4. Observe that the behavior is the same: Session appears, but nothing else happens.

Additional Information

  • Operating System: OS X
  • Theia Version: 96a3950
@colin-grant-work colin-grant-work added bug bugs found in the application debug issues that related to debug functionality labels Jun 6, 2022
@colin-grant-work
Copy link
Contributor Author

@JonasHelming, @tortmayr, this appears to be a problem with the RPC commit. Debugging is working at e1e200a and broken at 83d4308.

@colin-grant-work colin-grant-work added the critical critical bugs / problems label Jun 6, 2022
@tortmayr
Copy link
Contributor

tortmayr commented Jun 7, 2022

Thanks for reporting this. That's definitely a critical issue and I will have a look at it right away.

tortmayr added a commit to eclipsesource/theia that referenced this issue Jun 7, 2022
@tortmayr
Ensure that the Debug API is working with the new RPC
000ca5f 
After migrating to new binary RPC (eclipse-theia@83d4308) Debugging was no longer working as expected.
- Partly revert/Switch back to use a string-based message channel for Debug communication. 
- Rename the string-based `Channel` used in the Debug API to `DebugChannel` to avoid naming confusion with the default binary message `Channel`s.
- Introduce a `ForwardingDebugChannel` which can be used to wrap an arbitrary binary message `Channel` (i.e. the service websocket channel` in a `DebugChannel`

Fixes eclipse-theia#11263

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr mentioned this issue Jun 7, 2022
Closed
1 task
tortmayr added a commit to eclipsesource/theia that referenced this issue Jun 7, 2022
@tortmayr
Ensure that the Debug API is working with the new RPC
cd7db45 
After migrating to new binary RPC (eclipse-theia@83d4308) Debugging was no longer working as expected.
- Partly revert/Switch back to use a string-based message channel for Debug communication. 
- Rename the string-based `Channel` used in the Debug API to `DebugChannel` to avoid naming confusion with the default binary message `Channel`s.
- Introduce a `ForwardingDebugChannel` which can be used to wrap an arbitrary binary message `Channel` (i.e. the service websocket channel` in a `DebugChannel`

Fixes eclipse-theia#11263

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr mentioned this issue Jun 7, 2022
Merged
1 task
@tortmayr
Copy link
Contributor

tortmayr commented Jun 7, 2022

@colin-grant-work I have opened a PR that should fix the debugging issues: #11268

colin-grant-work pushed a commit to colin-grant-work/theia that referenced this issue Jun 8, 2022
@tortmayr @colin-grant-work
Ensure that the Debug API is working with the new RPC
5bf4b95 
After migrating to new binary RPC (eclipse-theia@83d4308) Debugging was no longer working as expected.
- Partly revert/Switch back to use a string-based message channel for Debug communication. 
- Rename the string-based `Channel` used in the Debug API to `DebugChannel` to avoid naming confusion with the default binary message `Channel`s.
- Introduce a `ForwardingDebugChannel` which can be used to wrap an arbitrary binary message `Channel` (i.e. the service websocket channel` in a `DebugChannel`

Fixes eclipse-theia#11263

Contributed on behalf of STMicroelectronics
JonasHelming pushed a commit that referenced this issue Jun 9, 2022
@tortmayr
Ensure that the Debug API is working with the new RPC (#11268)
57f6415 
After migrating to new binary RPC (83d4308) Debugging was no longer working as expected.
- Partly revert/Switch back to use a string-based message channel for Debug communication. 
- Rename the string-based `Channel` used in the Debug API to `DebugChannel` to avoid naming confusion with the default binary message `Channel`s.
- Introduce a `ForwardingDebugChannel` which can be used to wrap an arbitrary binary message `Channel` (i.e. the service websocket channel` in a `DebugChannel`

Fixes #11263

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr mentioned this issue Jul 20, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application critical critical bugs / problems debug issues that related to debug functionality
Projects
None yet
Milestone
No milestone
2 participants
@tortmayr @colin-grant-work