Ensure that the Debug API is working with the new RPC #11268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After migrating to new binary RPC (eclipse-theia@83d4308) Debugging was no longer working as expected. - Partly revert/Switch back to use a string-based message channel for Debug communication. - Rename the string-based `Channel` used in the Debug API to `DebugChannel` to avoid naming confusion with the default binary message `Channel`s. - Introduce a `ForwardingDebugChannel` which can be used to wrap an arbitrary binary message `Channel` (i.e. the service websocket channel` in a `DebugChannel` Fixes eclipse-theia#11263 Contributed on behalf of STMicroelectronics
colin-grant-work
approved these changes
Jun 8, 2022
2 tasks
msujew
approved these changes
Jun 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
After migrating to the new binary RPC protocol (83d4308), debugging is no longer working as expected.
The main reason for this an incomplete migration of the Debug API to the new binary message channels. In addition to being incomplete, this refactoring is also unnecessary. The Debug (Adapter) Protocol is completely string based anyway. Thus, there is no benefit in migrating to the binary protocol. So this PR fixes Debugging in Theia by
Channelused in the Debug API toDebugChannelto avoid naming confusion with the default binary message Channels.ForwardingDebugChannelwhich can be used to wrap an arbitrary binary messageChannel(i.e. the service websocket channel) in aDebugChannelFixes #11263
Contributed on behalf of STMicroelectronics
How to test
Run Mocha Testsdebug configuration.Review checklist
Reminder for reviewers