Identical expressions on both sides of || in git-quick-open-service#doBuildDefaultProjectPath

[JonasHelming]

Blocked for hackathon

See:

theia/packages/git/src/browser/git-quick-open-service.ts

Line 128 in 4d3d0c2

let projectPath = folderPath + '/' + (uriSplitted.pop() || uriSplitted.pop());

The same expression is used on both sides of a || operator, which is very confusing.

@tsmaeder : Do you want to add details and test instructions for this one?

• Operating System: latet
• Theia Version: latest

[tsmaeder]

@JonasHelming is there an actual observable problem behind this or is it just a code smell?

[JonasHelming]

@tsmaeder I did not investigate this in detail. "At least" a code smell, maybe an issue.

[tsmaeder]

This code is actually correct, but misleading: let's look at what split gives for the following string:

'foo/bar/zoz/'.split('/') = ['foo', 'bar', 'zoz', ""]

so if you evalutate uriSplitted.pop(), you'll get back '', which evalutes to false, so then the code invokes uriSplitted.pop() again, which this time evaluates to 'zoz'. Basically, it gets back the last non-emtpy element of the path.

[tsmaeder]

the "Git: clone" command is 100% broken: seems our quick pick implementation does not invoke the "execute" function in this case: since there is no "selected item", only a value in this case. Not usefule for Hackathon.

[JonasHelming]

@tsmaeder : Could you remove the label then or close the bug and search/create another one for you for the Hackathon, please

[tsmaeder]

Probably the code is still wrong when someone enters a uri like "https://github.com/my/repo///", but we can't verify it right now.