Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed QuickInput behavior on Enter #11980

Closed

Conversation

federicobozzini
Copy link
Contributor

What it does

It fixes #11979. When clicking enter the first element of a QuickInput is picked by default.

How to test

  1. Open a git-versioned project with Theia
  2. Click on the branch name in the status bar (the QuickInput to choose the branch to checkout is presented, first element of the list is "create new branch...")
  3. Press Enter. the first element is selected by default.

Review checklist

Reminder for reviewers

Signed-off-by: Federico Bozzini <[email protected]>
@msujew msujew added the quick-open issues related to the quick-open label Dec 12, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@federicobozzini unfortunately I believe the behavior is confusing for users as the first element is not highlighted with your change but is accepted with enter. I believe it should also be highlighted.

  1. start the application with a workspace under version control
  2. click the branch statusbar item
  3. there is no selection present
  4. press enter - the create branch is triggered

For reference VS Code correctly highlights the first element in this case.

@tsmaeder
Copy link
Contributor

Also consider the "gig clone" command as a test case for this fix, please. See #11900

@federicobozzini
Copy link
Contributor Author

Closing this since a better fix was provided by #12208 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-open issues related to the quick-open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuickInput is not picking the first element as a fallback on Enter
4 participants