Handle the case where no default terminal profile is set no startup #12191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
msujew
approved these changes
Feb 17, 2023
| this.profileService.onAdded(id => { | ||
| // extension contributions get read after this point: need to set the default profile if necessary | ||
| let defaultProfileId; | ||
| let defaultProfileId = undefined; |
There was a problem hiding this comment.
Minor: This gets implicitly typed as any
Suggested change
| let defaultProfileId = undefined; | |
| let defaultProfileId: string | undefined; |
There was a problem hiding this comment.
Strange: it seems trivial to infer the type here.
There was a problem hiding this comment.
TypeScript doesn't seem to do it anyway ¯\_(ツ)_/¯
Signed-off-by: Thomas Mäder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
We are handling the
contributes.terminalextension point later than we are initializing terminal profiles from the preferences. So the default profile in the preferences might not be present yet in the terminal profile registry when we read the preferences. So we try to set the default whenever a new profile is added. In this endeavor, we were not handling the case that no default profile is set in the preferences.Fixes #12119
How to test
Review checklist
Reminder for reviewers