full screen mode for main and bottom areas

[akosyakov]

fix #4668

TODO:

• exit on ESC - hard: it's colliding with monaco esc handlers
  • use CtrlCmd + M as in Eclipse, see full screen mode for main and bottom areas #4744 (comment)
• Toggle Maximized command
• Toggle Maximized context menu item

[AlexTugarev]

@akosyakov, I really like this feature! one thing though: I'd prefer to call it maximized mode instead of full screen mode, which in fact would be:

if (document.fullscreenEnabled) {
  document.body.requestFullscreen()
}

[akosyakov]

@AlexTugarev understood, how would you call a command Toggle Maximized?

[akosyakov]

It's simple and naive implementation that one can maximize the terminal and see the whole output easier, does not work nicely for all cases. Please try if you find it nice we can start with it.

[vince-fugnitto]

Maximizing editors in the main area works fine for me, there are some corner cases that don't work the best but they can always be improved iteratively.

Some cases do not work correctly for me for instance:

1. triggering a new terminal and maximizing it means I can no longer see the output or write in it (might be the xterm issue).
2. Complex main areas (two editors split with a widget) does not always recover well when minimizing. (this is likely a corner case so no need to spend too much time on it)
3. I wonder if it is possible if you maximize a single editor in the main area (with a split present) it will take the full size of the screen and not preserve the split.

[akosyakov]

triggering a new terminal and maximizing it means I can no longer see the output or write in it (might be the xterm issue).
Complex main areas (two editors split with a widget) does not always recover well when minimizing. (this is likely a corner case so no need to spend too much time on it)

These two i've tested and expect to work. If it does not work then it does not make sense. Which browser do you use?

I wonder if it is possible if you maximize a single editor in the main area (with a split present) it will take the full size of the screen and not preserve the split.

It is not easy. They get constantly resized by corresponding area. We would need to refactor shell to allow it. This PR does on level of css and it works nicely only for top-level areas.

[vince-fugnitto]

triggering a new terminal and maximizing it means I can no longer see the output or write in it (might be the xterm issue).
Complex main areas (two editors split with a widget) does not always recover well when minimizing. (this is likely a corner case so no need to spend too much time on it)

These two i've tested and expect to work. If it does not work then it does not make sense. Which browser do you use?

I am running the PR on Gitpod and Chrome :(

[kittaakos]

• exit on ESC - hard: it's colliding with monaco esc handlerd

Ctrl+M is the binding for Maximize Active View or Editor in Eclipse.
(I am using macOS, but if I remember correctly, the keybinding was the same on Windows too.)

Edit: fixed the command name taken from Eclipse.

[akosyakov]

I had forgotten to push on Friday, so you tested the old state 😬 Please have a look again.

@kittaakos good idea! I went with Eclipse shortcut.

@vince-fugnitto I can reproduce an issue with xterm. It is not related to this PR, but general issue which should be fixed by #4680

With multi editors it works nicely for me:

[vince-fugnitto]

It works great !
The only issue I had was with the terminal but as we both mentioned
it is likely due to xterm therefore I won't hold back this PR :)

[akosyakov]

I will await merging it before issues with xtermjs are sorted out.

[kittaakos]

Note: it cannot be ctrlcmd. Only ctrl is valid on OS X. Otherwise, you overrule macOS's minimize binding.

It is up to you what you pick, but I wrote Ctrl+M and you interpreted my comment as CtrlCmd+M

[akosyakov]

I did not interpret 😄 I've tried to use Eclipse key-shortcut. I wonder how Eclipse deals with it. Don't it also overrule Mac OS binding, if os then it should be fine for us as well.

[kittaakos]

I wonder how Eclipse deals with it.

It is ctrl+m in Eclipse on macOS and not cmd+m.

[akosyakov]

You are right! just checked it, will change

had to trust to internet less and check with latest Eclipse first :)

[akosyakov]

switched to ctrl+m, unfortunately terminals have already bindings for it, so it does not work for them

[akosyakov]

@kittaakos @vince-fugnitto @AlexTugarev xterm upgrade was merged. I've upgraded this PR to fix issues with unresponsive terminal after toggling maximization. I'm aways till the end of next week if you like it please merge yourself.

[kittaakos]

It looks great, unfortunately, toggling the maximized state does not work reliably with the keybinding. It is broken in the terminal, and it does not seem to work in the preview editor either.

it does not seem to work in the preview editor

I do not know how I managed to get the preview editor. But that's a separate issue presumably.

[kittaakos]

It is broken in the terminal

Most likely the same as #5152 (comment).

[akosyakov]

@kittaakos Would it be fine to address keybindings issue separately?

[kittaakos]

@kittaakos Would it be fine to address keybindings issue separately?

👍