Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable writeHandler registration for net sockets and websockets by default #4625

Closed
tsegismont opened this issue Feb 22, 2023 · 0 comments · Fixed by #4626
Closed

Disable writeHandler registration for net sockets and websockets by default #4625

tsegismont opened this issue Feb 22, 2023 · 0 comments · Fixed by #4626
Assignees
Milestone

Comments

@tsegismont
Copy link
Contributor

When a net socket is created, it registers a local consumer which address is given by io.vertx.core.net.NetSocket#writeHandlerID.

Similarly, when a websocket is created, it registers local consumers which addresses are given by io.vertx.core.http.WebSocketBase#binaryHandlerID and io.vertx.core.http.WebSocketBase#textHandlerID.

This puts some pressure on cluster managers when Vert.x is clustered, even if most users don't need the feature.

We shall disable write handlers registration by default (as we did for SockJS handler in vert-x3/vertx-web#1221).

This is a breaking (behavioral) change, but users will be able to switch the feature on with options.

@tsegismont tsegismont added this to the 4.4.0 milestone Feb 22, 2023
@tsegismont tsegismont self-assigned this Feb 22, 2023
tsegismont added a commit to tsegismont/vert.x that referenced this issue Feb 22, 2023
tsegismont added a commit to tsegismont/vert.x that referenced this issue Feb 28, 2023
tsegismont added a commit to tsegismont/vert.x that referenced this issue Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant