Update Vert.x to 4.5.4 #6666
Merged
Update Vert.x to 4.5.4 #6666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
force-pushed
the
update-vertx
branch
2 times, most recently
from
7c6bdfc
to
b4ccc81
Compare
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
siladu
reviewed
Mar 6, 2024
ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpService.java
Show resolved
Hide resolved
|
PR #6666? I always knew there was something unseemly about vertx ;) |
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Mar 8, 2024
* Update Vert.x to 4.5.4 Signed-off-by: Fabio Di Fabio <[email protected]> * Enable websocket write handlers Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* Update Vert.x to 4.5.4 Signed-off-by: Fabio Di Fabio <[email protected]> * Enable websocket write handlers Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: amsmota <[email protected]>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* Update Vert.x to 4.5.4 Signed-off-by: Fabio Di Fabio <[email protected]> * Enable websocket write handlers Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: amsmota <[email protected]>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* Update Vert.x to 4.5.4 Signed-off-by: Fabio Di Fabio <[email protected]> * Enable websocket write handlers Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Most advanced CI tests are deferred until PR approval, but you could:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTestsPR description
A small change was required to update Vert.x, since in the new version the CORS check have changed, and if using
.*to match any origin, the origin must have as protocol one of:http,httpsorftp, but since we also want to support browser extensions as origins, which have protocols likemoz-extension://, then the regex should be written has.*://.*In the version websocket write handlers are disabled by default, and since we use them, we need to enable them.
Fixed Issue(s)