Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error range for ETagRequired #387

Closed
xorye opened this issue May 23, 2019 · 0 comments · Fixed by #395 or #405
Closed

Fix error range for ETagRequired #387

xorye opened this issue May 23, 2019 · 0 comments · Fixed by #395 or #405
Assignees
Labels
bug Something isn't working validation
Milestone

Comments

@xorye
Copy link

xorye commented May 23, 2019

When multiple child elements are missing their end tags, the error range refers to the parent element's start tag, rather than the child element's.

This error does not happen when only one child is missing their end tag.

Example XML file:

<?xml version="1.0" encoding="utf-8"?>
<picture>
    <p1></p1>
    <p2>    <!-- missing end tag -->
    <p3>    <!-- missing end tag -->
</picture>

Result:
image

image

Error message:
The element type "p3" must be terminated by the matching end-tag "</p3>".

@NikolasKomonen NikolasKomonen added this to the v0.7.0 milestone May 23, 2019
@fbricon fbricon added bug Something isn't working validation labels May 24, 2019
xorye added a commit that referenced this issue May 29, 2019
fbricon pushed a commit that referenced this issue May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants