Fix error range for ETagRequired #395
Conversation
|
Please use self-descriptive commit messages, like |
|
Ok, I have just changed the commit message. |
|
LGTM but I'll let @NikolasKomonen or @angelozerr check if that's actually correct. |
|
@xorye Looks good to me One thing to change, and I know you didn't do this. But could you update the method name of 'findChildNode' https://github.com/angelozerr/lsp4xml/blob/ccc55276ec3505f93a3d654235560f5e3504a03b/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/utils/XMLPositionUtility.java#L205 to something like 'findUnclosedChildNodeWithName' Other than than it works great. |
findUnclosedChildNode will be fine |
|
Cool, changing it now. |
|
Actually, this function finds a closed child node. Not an unclosed one. I'll change it to findClosedChildNode |
| } | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| static DOMNode findChildNode(String childTag, List<DOMNode> children) { | ||
| static DOMNode findClosedChildNode(String childTag, List<DOMNode> children) { | ||
| for (DOMNode child : children) { | ||
| if (child.isElement() && childTag != null && childTag.equals(((DOMElement) child).getTagName()) | ||
| && !child.isClosed()) { |
Fixes #387 Signed-off-by: David Kwon <[email protected]>
This reverts commit c228469.
Fixes eclipse#395 Signed-off-by: azerr <[email protected]>
Fixes eclipse#395 Signed-off-by: azerr <[email protected]>
Fixes eclipse#395 Signed-off-by: azerr <[email protected]>
Fixes eclipse#395 Signed-off-by: azerr <[email protected]>
Fixes eclipse#395 Signed-off-by: azerr <[email protected]>
Fixes eclipse#395 Signed-off-by: azerr <[email protected]>
Fixes eclipse#395 Signed-off-by: azerr <[email protected]>
Fixes #387
Signed-off-by: David Kwon [email protected]