End Tag completion should be given higher priority than <!-- and <!CDATA[ #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!CDATA[ Fixes eclipse#1150 Signed-off-by: azerr <[email protected]>
|
Here the PR result, now snippet are after the end tag element:
/cc @mickaelistria |
| @@ -7,6 +7,7 @@ | |||
| "body": [ | |||
| "<!-- $1-->" | |||
| ], | |||
| "description": "Insert Comment" | |||
| "description": "Insert Comment", | |||
| "sortText": "ZZa" | |||
There was a problem hiding this comment.
sinze 'a'(== 97) > A(==65), should the sortext be zzA instaed to not make it lower than eg Hello ?
There was a problem hiding this comment.
Your usecase Hello works with my current PR:
There was a problem hiding this comment.
Maybe vscode does lozercase the sorttext or something. I'll try with LSP4E soon.
|
OK, I verified with LSP4E and this would be supposed to work (although some other bug in LSP4E is also in play here and needs to be fixed to get expected results), so it seems good to merge from LemMinX perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End Tag completion should be given higher priority than <!-- and <!CDATA[
Fixes #1150
Signed-off-by: azerr [email protected]