Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End Tag completion should be given higher priority than <!-- and <!CDATA[ #1150

Closed
ca-stefan-cordes opened this issue Jan 13, 2022 · 2 comments · Fixed by #1153
Closed

End Tag completion should be given higher priority than <!-- and <!CDATA[ #1150

ca-stefan-cordes opened this issue Jan 13, 2022 · 2 comments · Fixed by #1153
Milestone
0.18.3

Comments

@ca-stefan-cordes
Copy link

Currently when typing an End-Tag a pop up is asking for "Comment or End-Tag".

As comments in the text content of a node:
<version.maven-compiler-plugin>3.8.1<!-- some comment --></version.maven-compiler-plugin>
the continuous typing should just add the end tag as only option.

resulting in
<version.maven-compiler-plugin>3.8.1</version.maven-compiler-plugin>

This would enhance the typing of xml files.

(maybe when end tag already there type an "<" may suggest a comment)

See eclipse-m2e/m2e-core#490 (comment)
image
@mickaelistria
Copy link
Contributor

@angelozerr Is there a way from a lemminx extnsion to enforce some items to be shown before others ?

@angelozerr
Copy link
Contributor

@mickaelistria you want to show End with </version> BEFORE <!--, is that? If it that I agree with you and it's a lemminx bug. This End with </version> is managed by the Completion core of lemminx (not by an extension), so we need to sort at the end the snippet like comments, cdata.

If it that, please create an issue in LemMinx github project.

@mickaelistria mickaelistria transferred this issue from eclipse/lemminx-maven Jan 13, 2022
@mickaelistria mickaelistria mentioned this issue Jan 13, 2022
Closed
@mickaelistria mickaelistria changed the title End Tag automatically should be filled End Tag completion should be given higher priority than <!-- and <!CDATA[ Jan 13, 2022
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jan 14, 2022
@angelozerr
End Tag completion should be given higher priority than <!-- and
f821a0a 
<!CDATA[

Fixes eclipse#1150

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/lemminx that referenced this issue Jan 14, 2022
@angelozerr
End Tag completion should be given higher priority than <!-- and
572f7fa 
<!CDATA[

Fixes eclipse#1150

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jan 14, 2022
Merged
mickaelistria pushed a commit that referenced this issue Jan 14, 2022
@angelozerr @mickaelistria
End Tag completion should be given higher priority than <!-- and
f02d335 
<!CDATA[

Fixes #1150

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr added this to the 0.18.3 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.3
Development

Successfully merging a pull request may close this issue.

End Tag completion should be given higher priority than <!-- and <!CDATA[ angelozerr/lemminx
3 participants
@mickaelistria @angelozerr @ca-stefan-cordes