Improve ETagRequired error range

[angelozerr]

Improve ETagRequired error range

Fixes #876

Signed-off-by: azerr [email protected]

[angelozerr]

My code requires to be cleaned and I need to add some tests again, but I think we can start to play with it.

Basicly, this PR improves error range for diagnostic. For instance given this XML

<abc>
  <def/>

Before def was highlighted which is wrong and provided code action are wrong.. Today it highlights abc and provided code action to close abc.

Other case is :

<abc>
</def>

It higlights def although it should higlight abc. Th ePR fixes that and provides 2 code actions:

• one to close abc
• a second to rename def to abc.

When I fixed that I need to fix code action to close abc. There were a lot of bugs and I fixed (by adding new tests) and I support the eat of characters (ex : it fixes the issue #878)

To test correctly this PR, I suggest you do step by step. Ex :

write

<a

see if the error range is correct and code action too.

write

<a>

write

<a><b

write

<a><b>

etc...

[datho7561]

<foo>
  <bar><bar></</bar>
</foo>

Apply quickfix -->

<foo>
  <bar><bar</bar></bar>
</foo>

Apply quickfix -->

<foo>
  <bar><bar</bar>></bar>
</foo>

This behaviour is slightly different from what happens on master (on master the quickfixes don't help either), but this should probably be fixed in a different PR.

[datho7561]

Something else I found:

<foo>
  <bar><bar></bar>
  </bar></</bar>
</foo>

Apply quickfix -->

<foo</foo></foo>

[angelozerr]

Abandoned for #897