-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ETagRequired error range #897
Conversation
efcfbaa
to
a043eb3
Compare
This PR fixes error range for ETAgrequired, the main idea is to higlight the error from the start tag which is broken to the offset reported by Xerces: The start tag can be broken because:
As I had to fix CloseStartTagAction which is used for several error code,this PR fixes several issues: |
...c/main/java/org/eclipse/lemminx/extensions/contentmodel/participants/XMLSyntaxErrorCode.java
Outdated
Show resolved
Hide resolved
...pse/lemminx/extensions/contentmodel/participants/codeactions/ETagUnterminatedCodeAction.java
Outdated
Show resolved
Hide resolved
...org/eclipse/lemminx/extensions/contentmodel/participants/codeactions/CloseTagCodeAction.java
Show resolved
Hide resolved
a043eb3
to
c577e30
Compare
fixed |
5428526
to
3fa6e41
Compare
@datho7561 please review my PR (with vscode-xml and see if my code is understandable). Thanks |
...c/main/java/org/eclipse/lemminx/extensions/contentmodel/participants/XMLSyntaxErrorCode.java
Outdated
Show resolved
Hide resolved
...org/eclipse/lemminx/extensions/contentmodel/participants/codeactions/CloseTagCodeAction.java
Outdated
Show resolved
Hide resolved
...org/eclipse/lemminx/extensions/contentmodel/participants/codeactions/CloseTagCodeAction.java
Show resolved
Hide resolved
281c085
to
e7a9dd6
Compare
Fixes eclipse#876 Signed-off-by: azerr <[email protected]>
Improve ETagRequired error range
Fixes #876
Signed-off-by: azerr [email protected]