Remove duplicate _opcode at arm and x level

[jamesgua]

the member not found in other platforms: aarch64, p, riscv, z
the member is currently at OMR::Instruction level with protected attribution

Signed-off-by: Tao Guan [email protected]

[jamesgua]

@0xdaryl Although test failed on macOS but from the log it shows errors on
poll_functionality_basic, poll_functionality_many_sockets
I can hardly believe the change would have impact on those poll tests on socket communication. Maybe rerun the test can eliminate the noise? Thx!

[knn-k]

That is a known macOS porttest failure: #6516.

[knn-k]

The change looks OK to me for the ARM part.

All the platforms except Z seem to have the line TR::InstOpCode& getOpCode() { return _opcode; } in the platform-specific OMRInstruction.hpp. Perhaps we can also remove the definition, which can be done in a separate PR.

[jamesgua]

The change looks OK to me for the ARM part.

All the platforms except Z seem to have the line TR::InstOpCode& getOpCode() { return _opcode; } in the platform-specific OMRInstruction.hpp. Perhaps we can also remove the definition, which can be done in a separate PR.

Yes, it's done in #6640