Remove duplicate and non-extended methods in Instruction #6640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgua
requested review from
aviansie-ben,
0xdaryl,
knn-k and
mstoodle
as code owners
github-actions
bot
added
arch:aarch32
arch:aarch64
arch:power
arch:riscv
arch:x86
comp:compiler
labels
setOpCodeValue is void since most setters are void Signed-off-by: Tao Guan <[email protected]>
|
Keep getter/setter of OpCode methods at OMR::Instruction level and remove duplicated ones in each platform, for setOpCodeValue, checked that no references is checking the return value so remove it from each platform. |
|
Jenkins build all |
|
Segmentation fault with ppc linux. It looks the same as Issue #6556. |
|
I am going to merge this PR tomorrow if there are no other comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setOpCodeValue is void since most setters are void
Signed-off-by: Tao Guan [email protected]