Uncomment the code have 2 dependency with downstream projects #6672
Conversation
LinHu2016
requested review from
charliegracie,
youngar,
rwy7,
mstoodle and
0xdaryl
as code owners
LinHu2016
force-pushed
the
ProjectLoom_gc2
branch
from
71d4eed
to
31ebff2
Compare
|
Let's address inner fixupForwardedSlot here, too. It should return a result (a bool or a new/fixed-up value), so that the outter fixupForwardedSlot updates the slot only if it really changed. |
|
Remove 'depends on: eclipse-openj9/openj9#15603' comment from the commit message. In general, try to minimize references to downstream projects, including code comments. |
|
You can do this simplification now: #6683 (comment) |
LinHu2016
force-pushed
the
ProjectLoom_gc2
branch
from
31ebff2
to
75864ee
Compare
This (shouldRememberSlot simplification) has not been done, yet. |
LinHu2016
force-pushed
the
ProjectLoom_gc2
branch
from
75864ee
to
7a7f1e1
Compare
gc/base/standard/Scavenger.cpp
Outdated
| /* Could happen if we aborted before completing RS scan */ | ||
| return true; | ||
| } | ||
| if ((NULL != slotObjectPtr) && shouldRememberSlot(&slotObjectPtr)) { |
There was a problem hiding this comment.
seems like shouldRememberSlot already checks if NULL
Remove the temporary comments after the dependent downstream project has merged. Update Method fixupForwardedSlot return true or false for the condition to update heap object reference slot(we won't need to update the reference slot if the reference is not fixed up) in order to avoid potential reference slot overwriting(concurrent marking) during Concurrent scavenger back out case. Share method MM_Scavenger.shouldRememberSlot, remove duplicated logic for checking if should remember the slot. Signed-off-by: Lin Hu <[email protected]>
LinHu2016
force-pushed
the
ProjectLoom_gc2
branch
from
7a7f1e1
to
caed11e
Compare
|
Hi @babsingh, could you please review and merge the PR? the related personal build has passed compiling, there are still some infra issues blocking testing(https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/14081/), Thanks |
|
jenkins build all |
|
jenkins build zos |
1 similar comment
|
jenkins build zos |
|
@jdekonin @AdamBrousseau zOS builds have been failing consistently due to the below error. Can you please take a look at the machine setup? |
|
jenkins build zos |
|
Both zos machines show this failure intermittently. Not sure why. I re-enabled |
Remove the temporary comments after the dependent downstream project
has merged.
Update Method fixupForwardedSlot return true or false for the condition
to update heap object reference slot(we won't need to update the
reference slot if the reference is not fixed up) in order to avoid
potential reference slot overwriting(concurrent marking) during
Concurrent scavenger back out case.
Share method MM_Scavenger.shouldRememberSlot, remove duplicated logic
for checking if should remember the slot.
related: #6575
Signed-off-by: Lin Hu [email protected]