Fix testHashTableCorrectness issue #6683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinHu2016
requested review from
charliegracie,
youngar and
rwy7
as code owners
amicic
reviewed
Sep 1, 2022
amicic
reviewed
Sep 1, 2022
LinHu2016
force-pushed
the
ProjectLoom_gc
branch
2 times, most recently
from
0221cfa
to
c5dbb56
Compare
amicic
approved these changes
Sep 1, 2022
|
Hi @dsouzai, Could you please review and merge this PR? it is for fixing the blocker issue (eclipse-openj9/openj9#15791), Thanks |
|
I will review it. |
Thanks @babsingh |
|
fixupForwardedSlot(mrobjectptr_t *slotPtr) has been created for sharing code between scanMixObject and scan Java stack of continuation Object in PR6575, we need to pull concurrent scavenger and backout conditions outside to avoid racing condition to update slot reference during concurrent marking. - also update initialize scanCache->_shouldBeRemembered earlier to avoid overwriting the flag, which could be updated via getObjectScanner(). Signed-off-by: Lin Hu <[email protected]>
LinHu2016
force-pushed
the
ProjectLoom_gc
branch
from
c5dbb56
to
4ce58d4
Compare
|
@babsingh there are jenkins issues, the personal build is not very stable, but the change for this PR has passed the grinder tests for the related issue. https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/14050/ |
|
jenkins build all |
babsingh
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: eclipse-openj9/openj9#15791
Signed-off-by: Lin Hu [email protected]