WIP change cursor to hand cursor when hovering over the tree and grabbing cursor when dragging the tree #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bing cursor when dragging the tree
|
I'm reviewing the documentation on d3 drag in order to get the cursor to change to the grabbing cursor when dragging across the tree. It mentioned that I would need d3-drag npm package, so those files are also included in my PR. |
|
Hi @kellydoleo, quick tip: node_modules should never be push to a repo, to prevent futur commit I added it to .gitignore |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've managed to update the cursor to a hand/grab cursor when hovering over the tree on the edam browser. This would allow users to know they can drag the tree. However, I'm still attempting to have the cursor change when dragging the tree @bryan-brancotte if you have any recommendations on where I can look more into this, I would greatly appreciate any help!