[Edge-core][common driver][pmbus][ym2651y.c] When … #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…psu_power_good is failed, temperature return 1023 degree. [why to do]: The driver will poll for 3 seconds at a time to update the pmbus value. Before modification, psu_power_good = failed ==>The temperature will be returned as 0 (degrees). This will cause the sonic to send syslog when the psu is powered up, but detect 0 degrees before updating the correct temperature. (misjudgment) Therefore, it is necessary to modify the value that when psu_power_good = failed ==> the temperature returns 1023 (degrees), so that the python program can know that the status of 1023 is for power_good is failed value(befor update the correct temperature value).
ec-michael-shih
changed the title
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
Apr 30, 2024
Why I did it:
Testbed report indicates related psu test failed.
How I dit it:
Sync from:
- sonic-net/sonic-buildimage#13815
- edge-core#6
- edge-core#23
How to verify it:
Test pass on testbed
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
May 3, 2024
Why I did it:
Testbed test reports related PSU test failed.
How I dit it:
Sync PMBUS driver from:
- sonic-net/sonic-buildimage#13815
- edge-core#6
- edge-core#23
How to verify it:
show platform firmware
show platform syseeprom
show platform psustatus
show platform temperature
show platform fan
tigerfu000
pushed a commit
to tigerfu000/ec-sonic-buildimage
that referenced
this pull request
May 3, 2024
Why I did it:
Testbed test reports related PSU test failed.
How I dit it:
Sync PMBUS driver from:
- sonic-net/sonic-buildimage#13815
- edge-core#6
- edge-core#23
How to verify it:
show platform firmware
show platform syseeprom
show platform psustatus
show platform temperature
show platform fan
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…psu_power_good is failed, temperature return 1023 degree.
Why I did it
The driver will poll for 3 seconds at a time to update the pmbus value. Before modification, psu_power_good = failed ==>The temperature will be returned as 0 (degrees). This will cause the sonic to send syslog when the psu is powered up, but detect 0 degrees before updating the correct temperature. (misjudgment)
How I did it
Therefore, it is necessary to modify the value that when psu_power_good = failed ==> the temperature returns 1023 (degrees), so that the python program can know that the status of 1023 is for power_good is failed value(befor update the correct temperature value).
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)