Rename kms to keyservice #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There was a problem hiding this comment.
Same thing as with the azure driver: edgelesssys/constellation-azuredisk-csi-driver#35 (review)
kms was renamed to keyservice in Constellation. This commit keeps things consistent in both repos.
* make chart deployable standalone by adding global section * make keyservice service name configurable
derpsteb
force-pushed
the
fix/kms-rename
branch
from
00c20b9
to
05fea44
Compare
daniel-weisse
approved these changes
Jan 13, 2023
daniel-weisse
pushed a commit
that referenced
this pull request
Apr 11, 2023
* Rename kms to keyservice kms was renamed to keyservice in Constellation. This commit keeps things consistent in both repos.
daniel-weisse
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Rename kms to keyservice kms was renamed to keyservice in Constellation. This commit keeps things consistent in both repos.
daniel-weisse
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Rename kms to keyservice kms was renamed to keyservice in Constellation. This commit keeps things consistent in both repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep things consistent with Constellation repo.
Necessary because of: edgelesssys/constellation#943