kms: rename kms to keyservice

[derpsteb]

Proposed change(s)

• Rename kms service to keyservice

Additional info

• In light of extending our eKMS support it will be helpful to have a tighter use of the word "KMS".
  KMS should refer to the actual component that manages keys. The keyservice, also called KMS in the constellation code, does not manage keys itself. It talks to a KMS backend, which in turn does the actual key management.
• Hope I caught all relevant occurences. The term KMS is still used, e.g. for the different KMS clients in the keyservice folder
• Rebuilt join-service and keyservice (was kmsserver) images
• GCP, 2+3, sonobuoy quick, 1.25
• Azure, 2+3, sonobuoy quick, 1.25
• AWS, 2+3, sonobuoy quick, 1.25
• Fix for go-generate errors in gcp driver: PR
• Fix for go-generate errors in azure driver: PR

Checklist

• Update docs
• Add labels (e.g., for changelog category)
• Link to Milestone

[netlify]

✅ Deploy Preview for constellation-docs canceled.

Name	Link
🔨 Latest commit	6745cea
🔍 Latest deploy log	https://app.netlify.com/sites/constellation-docs/deploys/63c528c08d67dc0009ad73c8

[daniel-weisse]

Looks good to me overall.
There is currently some inconsistency with the capitalization of KeyService.
IMO, it should be either written as KeyService, keyservice, depending on the circumstances (Also see JoinService, and joinservice). Currently there are cases where its also written as Keyservice.

CSI charts should also not be changed in this repo, as this wil conflict with the generate workflow, but needs to be updated upstream.
IMO, this has no high priority as the naming there is not user facing, but I will try to get it in with the next release.

[derpsteb]

Regarding CSI charts: We have to add the changes in the constellation repo once they happened upstream, don't we?

[daniel-weisse]

Just created v1.1.1 releases for the CSI drivers.
You should be able to simply update the target branch in cli/internal/helm/update-csi-charts.sh and rerun the Go generate command to get the changes.