Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http2 #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support http2 #66

wants to merge 2 commits into from

Conversation

leaves4j
Copy link

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from dead-horse April 24, 2018 09:50
@leaves4j
Copy link
Author

eggjs/egg#898

@leaves4j
Copy link
Author

leaves4j commented Apr 25, 2018 via email

@leaves4j
Copy link
Author

I found that the ts unit test failed in ci. Is this PR affecting the ts? @atian25

server = require('https').createServer(httpsOptions, app.callback());
}

if (options.http2) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need testcase

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will add test cases later. This may be a bit complicated as supertest does not support http2.

@po35
Copy link

po35 commented Aug 1, 2019

Out of curiosity, does egg now support http2 (without nginx) or not? koa was perfectly able to run on http2. CCing @dead-horse @leaves4j

@atian25 atian25 requested a review from fengmk2 August 8, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants