added localization logic in subtenant call and remove check in location service #1381

aaradhya-egov · 2024-09-10T11:50:55Z

No description provided.

coderabbitai · 2024-09-10T11:51:07Z

Walkthrough

The changes across the files primarily focus on enhancing the handling of tenant data and simplifying the logic for enabling functionalities within various components. Key modifications include ensuring safe access to tenant arrays, standardizing the use of localization keys, and refining conditions for enabling searches based on selected criteria. These adjustments streamline the code and improve data retrieval processes without altering the exported entities in most cases.

Changes

File Path	Change Summary
`.../useTenantManagementSearch.js`	Updated `tenantManagementSearchService` to ensure tenants array is defined and added `i18nKey` to tenant objects for localization.
`.../LocationSelection.js`	Refactored tenant data retrieval to always call `useTenants`, removed destructuring of `hookResult`, and standardized `optionsKey` to always use `"i18nKey"`.
`.../SelectAddress.js`	Removed `requestCriteria`, updated enabling conditions for tenant management search to check both `selectedCity` and `hierarchyType`, and standardized `optionsKey` to `"i18nKey"`.
`.../CreateComplaint/index.js`	Modified `enabled` condition for `useTenantManagementSearch` to require both `cityData` and `hierarchyType`, and simplified `optionKey` to always use `"i18nKey"`.

Sequence Diagram(s)

sequenceDiagram
    participant Component
    participant Hook
    participant API

    Component->>Hook: Call useTenants()
    Hook->>API: Fetch tenant data
    API-->>Hook: Return tenant data
    Hook-->>Component: Provide tenant data with i18nKey

🐰 In the meadow where bunnies play,
New changes hop in, brightening the day!
With keys for i18n, oh what a delight,
Tenant data dances, all shining and bright.
Simplified paths, a clear, joyful tune,
Hooray for the updates, we’ll sing 'neath the moon! 🌙✨

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 46b1f53 and 8533789.

Files selected for processing (1)

micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useTenantManagementSearch.js (3 hunks)

Additional context used

Path-based instructions (1)

micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useTenantManagementSearch.js (1)

Pattern **/*.js: check

Additional comments not posted (1)

micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useTenantManagementSearch.js (1)

16-25: The changes address the suggestions from the past review comments.

The code changes handle potential undefined values in the response object and transform the tenant data to include a localized key, as suggested in the past review comments.

These changes improve the robustness and functionality of the tenantManagementSearchService function.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

.../web/micro-ui-internals/packages/modules/pgr/src/pages/citizen/Create/Steps/SelectAddress.js

...o-ui/web/micro-ui-internals/packages/modules/pgr/src/pages/employee/CreateComplaint/index.js

…/citizen/Create/Steps/SelectAddress.js Co-authored-by: nabeelmd-eGov <[email protected]>

…/employee/CreateComplaint/index.js Co-authored-by: nabeelmd-eGov <[email protected]>

jagankumar-egov · 2024-09-10T12:08:10Z

micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useTenantManagementSearch.js

+  const tenants = response?.Tenants || [];
+  const modifiedTenants = tenants.map(tenant => {
+    const tenantName = tenant?.code || '';
+    const formattedName = tenantName.replace(/\./g, '_').toUpperCase();


Use the transform locale method

micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useTenantManagementSearch.js

…seTenantManagementSearch.js

aaradhya-egov added 2 commits September 10, 2024 17:17

bugs

a0096cc

fix

8a019b9

aaradhya-egov requested a review from a team as a code owner September 10, 2024 11:50

aaradhya-egov changed the title ~~Q3 sprint~~ added localization logic in subtenant call and remove check in location service Sep 10, 2024

coderabbitai bot previously approved these changes Sep 10, 2024

View reviewed changes

nabeelmd-eGov reviewed Sep 10, 2024

View reviewed changes

Update micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages…

93abbed

…/citizen/Create/Steps/SelectAddress.js Co-authored-by: nabeelmd-eGov <[email protected]>

aaradhya-egov dismissed coderabbitai[bot]’s stale review via 93abbed September 10, 2024 12:03

aaradhya-egov and others added 2 commits September 10, 2024 17:33

Update micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages…

d072d7e

…/citizen/Create/Steps/SelectAddress.js Co-authored-by: nabeelmd-eGov <[email protected]>

Update micro-ui/web/micro-ui-internals/packages/modules/pgr/src/pages…

682314a

…/employee/CreateComplaint/index.js Co-authored-by: nabeelmd-eGov <[email protected]>

coderabbitai bot previously approved these changes Sep 10, 2024

View reviewed changes

Merge branch 'develop' into q3-sprint

46b1f53

nabeelmd-eGov previously approved these changes Sep 10, 2024

View reviewed changes

jagankumar-egov requested changes Sep 10, 2024

View reviewed changes

nabeelmd-eGov reviewed Sep 10, 2024

View reviewed changes

micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/useTenantManagementSearch.js Outdated Show resolved Hide resolved

Update micro-ui/web/micro-ui-internals/packages/libraries/src/hooks/u…

8533789

…seTenantManagementSearch.js

nabeelmd-eGov dismissed stale reviews from coderabbitai[bot] and themself via 8533789 September 10, 2024 14:39

coderabbitai bot approved these changes Sep 10, 2024

View reviewed changes

jagankumar-egov approved these changes Sep 11, 2024

View reviewed changes

jagankumar-egov merged commit 07be27a into develop Sep 11, 2024
2 checks passed

jagankumar-egov deleted the q3-sprint branch September 11, 2024 04:14

This was referenced Sep 11, 2024

Develop #160

Open

side bar #1384

Merged

added logic for undefined tenant in header and add employe in view url page #1385

Merged

fix #1391

Merged

coderabbitai bot mentioned this pull request Oct 4, 2024

Dss init updated #1454

Merged

This was referenced Oct 17, 2024

Hrms bounday service #1544

Open

added city logic for multi root tenant #1565

Merged

coderabbitai bot mentioned this pull request Oct 22, 2024

fix #1611

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added localization logic in subtenant call and remove check in location service #1381

added localization logic in subtenant call and remove check in location service #1381

aaradhya-egov commented Sep 10, 2024

coderabbitai bot commented Sep 10, 2024 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

jagankumar-egov Sep 10, 2024

nabeelmd-eGov Sep 10, 2024

added localization logic in subtenant call and remove check in location service #1381

added localization logic in subtenant call and remove check in location service #1381

Conversation

aaradhya-egov commented Sep 10, 2024

coderabbitai bot commented Sep 10, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jagankumar-egov Sep 10, 2024

Choose a reason for hiding this comment

nabeelmd-eGov Sep 10, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Sep 10, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)