Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted sms change for arrears #763

Merged
merged 1 commit into from
Apr 4, 2024
Merged

reverted sms change for arrears #763

merged 1 commit into from
Apr 4, 2024

Conversation

Saloni-eGov
Copy link
Collaborator

@Saloni-eGov Saloni-eGov commented Apr 4, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Updated billing information to only show the total amount, removing the display of arrears for clarity.

@pradeepkumarcm-egov pradeepkumarcm-egov merged commit 7c10c08 into master Apr 4, 2024
1 check passed
@pradeepkumarcm-egov pradeepkumarcm-egov deleted the SMS-Changes branch April 4, 2024 07:41
Copy link

coderabbitai bot commented Apr 4, 2024

Walkthrough

The recent modification in the codebase focuses on adjusting the bill presentation logic within the DemandService.java file. Specifically, the update removes the display of arrears from the bill amounts, ensuring that users are now presented with only the total bill amount. This change aims to simplify the billing information for better clarity and understanding.

Changes

File Path Change Summary
.../wscalculation/service/DemandService.java Modified message string logic to exclude arrears display, showing only the total bill amount.

Poem

🐰✨
In the land of code, where logic trees grow,
A rabbit hopped, tweaking flows as it goes.
"No more arrears in the sight," it decreed,
"Just totals shining, clear as can be."
With every hop, the code did align,
Leaving a trail of clarity, oh so fine.
🌟📜

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between cbef403 and c25dcf6.
Files selected for processing (1)
  • municipal-services/ws-calculator/src/main/java/org/egov/wscalculation/service/DemandService.java (1 hunks)

@@ -383,7 +383,7 @@ private void sendDownloadBillSMSNotification(RequestInfo requestInfo, String ten
BigDecimal arrears=totalamount.subtract(demandAmount);
if(arrears.compareTo(BigDecimal.ZERO)>0)
{
messageString = messageString.replace("{billamount}", totalamount.toString()+"(includes Rs."+ arrears.toString()+ " arrears)");
messageString = messageString.replace("{billamount}", totalamount.toString());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the conditional logic that differentiates the message based on the presence of arrears, as the objective is to simplify the bill notification by only showing the total bill amount.

-				if(arrears.compareTo(BigDecimal.ZERO)>0)
-				{
-					messageString = messageString.replace("{billamount}", totalamount.toString());
-				}
-				else
-				{
					messageString = messageString.replace("{billamount}", totalamount.toString());
-				}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
messageString = messageString.replace("{billamount}", totalamount.toString());
messageString = messageString.replace("{billamount}", totalamount.toString());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants