-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverted sms change for arrears #763
Conversation
WalkthroughThe recent modification in the codebase focuses on adjusting the bill presentation logic within the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@@ -383,7 +383,7 @@ private void sendDownloadBillSMSNotification(RequestInfo requestInfo, String ten | |||
BigDecimal arrears=totalamount.subtract(demandAmount); | |||
if(arrears.compareTo(BigDecimal.ZERO)>0) | |||
{ | |||
messageString = messageString.replace("{billamount}", totalamount.toString()+"(includes Rs."+ arrears.toString()+ " arrears)"); | |||
messageString = messageString.replace("{billamount}", totalamount.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the conditional logic that differentiates the message based on the presence of arrears, as the objective is to simplify the bill notification by only showing the total bill amount.
- if(arrears.compareTo(BigDecimal.ZERO)>0)
- {
- messageString = messageString.replace("{billamount}", totalamount.toString());
- }
- else
- {
messageString = messageString.replace("{billamount}", totalamount.toString());
- }
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
messageString = messageString.replace("{billamount}", totalamount.toString()); | |
messageString = messageString.replace("{billamount}", totalamount.toString()); |
Summary by CodeRabbit