Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverted sms change for arrears #763

Merged
merged 1 commit into from
Apr 4, 2024
Merged

reverted sms change for arrears #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...al-services/ws-calculator/src/main/java/org/egov/wscalculation/service/DemandService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ private void sendDownloadBillSMSNotification(RequestInfo requestInfo, String ten
BigDecimal arrears=totalamount.subtract(demandAmount);
if(arrears.compareTo(BigDecimal.ZERO)>0)
{
messageString = messageString.replace("{billamount}", totalamount.toString()+"(includes Rs."+ arrears.toString()+ " arrears)");
messageString = messageString.replace("{billamount}", totalamount.toString());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the conditional logic that differentiates the message based on the presence of arrears, as the objective is to simplify the bill notification by only showing the total bill amount.

-				if(arrears.compareTo(BigDecimal.ZERO)>0)
-				{
-					messageString = messageString.replace("{billamount}", totalamount.toString());
-				}
-				else
-				{
					messageString = messageString.replace("{billamount}", totalamount.toString());
-				}
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
messageString = messageString.replace("{billamount}", totalamount.toString());
messageString = messageString.replace("{billamount}", totalamount.toString());

}
else
{
Expand Down