Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug in ArchiveExtractor that caused it to fail on case-insens… #843

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Fixed a bug in ArchiveExtractor that caused it to fail on case-insens… #843

merged 3 commits into from
Oct 30, 2019

Conversation

MikeThomsen
Copy link
Contributor

…itive file systems.

Summary

Tests and Documentation

@MikeThomsen MikeThomsen mentioned this pull request Aug 26, 2019
Open
@eirslett
Copy link
Owner

Thanks! Looks like this patch is needed by more people (#813) but the tests fail on Travis... could you see if you can figure out the reason why, and make them pass somehow?

@MikeThomsen
Copy link
Contributor Author

@eirslett I'll try to find some time soon to figure out what's going on.

@MikeThomsen
Copy link
Contributor Author

It was an assert in yarn-integration/verify.groovy that was causing it. The relevant line it was looking for no longer appears at all in the build log. Left a reminder TODO for you to see if that part of the test needs something new.

eirslett
eirslett reviewed Oct 27, 2019
View reviewed changes
...ugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/ArchiveExtractor.java Outdated
return false;
}

boolean retVal = true;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this stuff going on? Isn't it easier with destPath.toLowerCase().startsWith(destDir.toLowerCase())?

...ugin-core/src/main/java/com/github/eirslett/maven/plugins/frontend/lib/ArchiveExtractor.java Outdated
* @return
*/
private boolean startsWithPath(String destPath, String destDir) {
if (destDir.startsWith(destDir)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this check always be true? Is it supposed to be destPath?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a typo on my part.

@eirslett
Copy link
Owner

ok, thank you!

@eirslett eirslett merged commit 7d6b690 into eirslett:master Oct 30, 2019
@arminha arminha mentioned this pull request Dec 5, 2019
Merged
@eirslett
Copy link
Owner

There we go, 1.9.0 is released, merry christmas! 🎅 ❄️ 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirslett eirslett eirslett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeThomsen @eirslett