Fix regression when extracting tar archive to a path containig a symlink #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test extraction of malicious tar files * test extraction of a tar file into path with a symlink (this is a test for the fix in commit 6175368)
…eated Files.createSymbolicLink can also fail with an IOException when the user doesn't have the rights to create a symlink. For example on Windows 10 as normal user withouth admin rights.
|
+1 for the fix and a release this year! Thanks :-) |
|
Ok, let's do this! |
|
There we go, 1.9.0 is released, merry christmas! 🎅 ❄️ 🎄 |
|
Merry Christmas! 🤶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally fixed in pull request #816, but got lost when pull request #843 got merged.
This pull request fixes the issue again and adds unit tests to test the relevant code in the DefaultArchiveExtractor.