Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-json-specs.yml: add container_metadata_discovery.json #2156

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Aug 10, 2023

What does this pull request do?

Update the updatecli pipeline for the automation regarding the json specs.

Why is it important?

container_metadata_discovery.json is a new file while cgroup_parsing.json has been removed.

Otherwise the automation fails

https://github.com/elastic/apm-agent-dotnet/actions/runs/5817529661/job/15772321433

Related issues

@v1v v1v requested review from a team August 10, 2023 06:29
@v1v v1v self-assigned this Aug 10, 2023
reakaleek
reakaleek previously approved these changes Aug 10, 2023
@Mpdreamz
Copy link
Member

Thanks @v1v, This PR is now in a state where the file is gone and we need to update the test.

Will work on ammending this PR tomorrow.

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 09ce76b into elastic:main Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants