-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-json-specs.yml: add container_metadata_discovery.json #2156
Merged
Mpdreamz
merged 9 commits into
elastic:main
from
v1v:feature/updatecli-update-json-specs
Jun 5, 2024
Merged
update-json-specs.yml: add container_metadata_discovery.json #2156
Mpdreamz
merged 9 commits into
elastic:main
from
v1v:feature/updatecli-update-json-specs
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
previously approved these changes
Aug 10, 2023
Thanks @v1v, This PR is now in a state where the file is gone and we need to update the test. Will work on ammending this PR tomorrow. |
stevejgordon
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Update the
updatecli
pipeline for the automation regarding the json specs.Why is it important?
container_metadata_discovery.json
is a new file whilecgroup_parsing.json
has been removed.Otherwise the automation fails
https://github.com/elastic/apm-agent-dotnet/actions/runs/5817529661/job/15772321433
Related issues