Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify spec for cgroups v2 container ID parsing #807

Merged
merged 6 commits into from
Jul 10, 2023

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jun 23, 2023

Spec for capturing container ID when cgroups v2 is used #523

  • May the instrumentation collect sensitive information, such as secrets or PII (ex. in headers)?
    • No
      • Why? container ID is not sensitive information and is already captured
  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Approved by at least 2 agents + PM (if relevant)
  • Merge after 7 days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.
  • Create implementation issues through the meta issue template (this will automate issue creation for individual agents)
  • If this spec adds a new dynamic config option, add it to central config. n/a

specs/agents/metadata.md Outdated Show resolved Hide resolved
specs/agents/metadata.md Outdated Show resolved Hide resolved
@basepi
Copy link
Contributor

basepi commented Jun 27, 2023

Add the /proc/self/cgroup to the json test case with the content: 0::/ so we can test fallback

@SylvainJuge
Copy link
Member Author

SylvainJuge commented Jun 28, 2023

Update after review feedback from @SergeyKleyman, we now have a single JSON for testing. The existing cgroup_parsing.json is currently only used by Java and .NET agents so I think it's fine to remove it in this PR.

Also, please note that adding/modifying json tests also require to modify .ci/updatecli.d/update-json-specs.yml in every agent repository. I'll check with the robots team to see if we could improve this in the future (see internal linked issue below this comment for details).

@SylvainJuge SylvainJuge changed the title Add spec for cgroups v2 container ID parsing Modify spec for cgroups v2 container ID parsing Jun 28, 2023
@SylvainJuge SylvainJuge marked this pull request as ready for review July 3, 2023 07:58
@SylvainJuge SylvainJuge requested review from a team as code owners July 3, 2023 07:58
@SylvainJuge SylvainJuge removed request for a team July 3, 2023 07:58
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Like that its now contained to 1 test file too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants