sampling: require a default policy #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
tailsampling-require-default-policy
branch
from
e33e96c
to
4bffdee
Compare
Codecov Report
@@ Coverage Diff @@
## master #4729 +/- ##
==========================================
+ Coverage 76.65% 76.75% +0.10%
==========================================
Files 166 166
Lines 10211 10232 +21
==========================================
+ Hits 7827 7854 +27
+ Misses 2384 2378 -6
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
axw
force-pushed
the
tailsampling-require-default-policy
branch
2 times, most recently
from
25827a4
to
79bd19b
Compare
If runServer returns an error without Stop being called, signal the "done" channel.
axw
force-pushed
the
tailsampling-require-default-policy
branch
from
79bd19b
to
73c5677
Compare
simitt
approved these changes
Feb 15, 2021
|
Looks like an unrelated test failure. |
|
jenkins run the tests please |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 19, 2021
* sampling: require a default policy * beater/config: validate policies here too * beater: don't hang if runServer returns error If runServer returns an error without Stop being called, signal the "done" channel. # Conflicts: # changelogs/head.asciidoc
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 19, 2021
* sampling: require a default policy * beater/config: validate policies here too * beater: don't hang if runServer returns error If runServer returns an error without Stop being called, signal the "done" channel. # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Feb 19, 2021
* sampling: require a default policy * beater/config: validate policies here too * beater: don't hang if runServer returns error If runServer returns an error without Stop being called, signal the "done" channel. # Conflicts: # changelogs/head.asciidoc
axw
added a commit
that referenced
this pull request
Feb 19, 2021
* sampling: require a default policy * beater/config: validate policies here too * beater: don't hang if runServer returns error If runServer returns an error without Stop being called, signal the "done" channel. # Conflicts: # changelogs/head.asciidoc
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Feb 22, 2021
…chemas-to-agents * upstream/master: (111 commits) Introduce metricset.name (elastic#4857) processor/otel: test service.version handling (elastic#4853) docs: Add PHP agent information to shared docs (elastic#4740) Script for faster development workflow (elastic#4731) Update to elastic/beats@1b31c26 (elastic#4763) backport: add 7.12 to .backportrc.json (elastic#4807) backport: enable auto-merge on backport PRs (elastic#4777) Support for Node.js profiles (elastic#4728) docs: readds .NET link (elastic#4764) [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746) ci: set proper parameters for the tar step (elastic#4696) docs: add 7.11.1 release notes (elastic#4727) Disable sourcemap upload endpoint when data streams enabled (elastic#4735) Add service name to dataset field (elastic#4674) Update to elastic/beats@ba423212a660 (elastic#4733) sampling: require a default policy (elastic#4729) processor/otel: add unit test for span status (elastic#4734) Add support for consuming OTLP/gRPC metrics (elastic#4722) [apmpackage] Add config options supported in ESS (elastic#4690) Use the apm-server version everywhere* (elastic#4725) ...
v1v
added a commit
to v1v/apm-server
that referenced
this pull request
Feb 22, 2021
…te-schema-json-1 * upstream/master: (111 commits) Introduce metricset.name (elastic#4857) processor/otel: test service.version handling (elastic#4853) docs: Add PHP agent information to shared docs (elastic#4740) Script for faster development workflow (elastic#4731) Update to elastic/beats@1b31c26 (elastic#4763) backport: add 7.12 to .backportrc.json (elastic#4807) backport: enable auto-merge on backport PRs (elastic#4777) Support for Node.js profiles (elastic#4728) docs: readds .NET link (elastic#4764) [DOCS] Fixes URLs on Secure communication with APM Agents page (elastic#4746) ci: set proper parameters for the tar step (elastic#4696) docs: add 7.11.1 release notes (elastic#4727) Disable sourcemap upload endpoint when data streams enabled (elastic#4735) Add service name to dataset field (elastic#4674) Update to elastic/beats@ba423212a660 (elastic#4733) sampling: require a default policy (elastic#4729) processor/otel: add unit test for span status (elastic#4734) Add support for consuming OTLP/gRPC metrics (elastic#4722) [apmpackage] Add config options supported in ESS (elastic#4690) Use the apm-server version everywhere* (elastic#4725) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
When tail-based sampling is enabled, require a default policy to be defined. A default policy is one with no criteria, only a sampling rate which applies to any traces that does not match any other policy.
Without a default policy, the default behaviour is to drop traces that do not match any policy. By requiring a default we ensure that this behaviour is intentional: either drop (sample_rate=0) or not (sample_rate>0).
Checklist
- [ ] Documentation has been updated(no docs yet)How to test these changes
Run apm-server with
-E apm-server.sampling.tail.enabled, check that it exits with an error because no default policy is defined.Related issues
Closes #4583