[filebeat][httpjson]- improved error handling during pagination with …

…chaining & split processor (#34127) * added a safety check to avoid unnecessary panics * updated asciidoc * updated asciidoc
elastic · Dec 28, 2022 · 4e70b69 · 4e70b69
1 parent 2c21577
commit 4e70b69
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -51,6 +51,7 @@ https://github.com/elastic/beats/compare/v8.2.0\...main[Check the HEAD diff]
 
 
 *Filebeat*
+- [httpsjon] Improved error handling during pagination with chaining & split processor {pull}34127[34127]
 - [Azure blob storage] Added support for more mime types & introduced offset tracking via cursor state. {pull}33981[33981]
 - Fix EOF on single line not producing any event. {issue}30436[30436] {pull}33568[33568]
 - Fix handling of error in states in direct aws-s3 listing input {issue}33513[33513] {pull}33722[33722]

diff --git a/x-pack/filebeat/input/httpjson/request.go b/x-pack/filebeat/input/httpjson/request.go
@@ -667,7 +667,12 @@ func (r *requester) processChainPaginationEvents(stdCtx context.Context, trCtx *
 		n += processAndPublishEvents(chainTrCtx, events, publisher, i < len(r.requestFactories), r.log)
 	}
 
-	defer httpResp.Body.Close()
+	defer func() {
+		if httpResp != nil && httpResp.Body != nil {
+			httpResp.Body.Close()
+		}
+	}()
+
 	return n, nil
 }