Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][httpjson]- improved error handling during pagination with chaining & split processor #34127

Merged
merged 3 commits into from
Dec 28, 2022
Merged

[filebeat][httpjson]- improved error handling during pagination with chaining & split processor #34127

merged 3 commits into from
Dec 28, 2022

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Dec 27, 2022 •
edited
Loading

Type of change

  • Bug

What does this PR do?

Adds a safety check to response.Body.Close to avoid unnecessary panics

Why is it important?

Improves stability, removing edge-case panics

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@ShourieG ShourieG requested a review from a team as a code owner December 27, 2022 11:00
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 27, 2022
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label 8.7-candidate labels Dec 27, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 27, 2022
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label backport-v8.6.0 Automated backport with mergify labels Dec 27, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 27, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 27, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-27T11:02:18.250+0000

  • Duration: 75 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 2574
Skipped 167
Total 2741

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ShourieG ShourieG merged commit 4e70b69 into elastic:main Dec 28, 2022
@mergify mergify bot mentioned this pull request Dec 28, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 28, 2022
@ShourieG @mergify
[filebeat][httpjson]- improved error handling during pagination with …
d647371 
…chaining & split processor (#34127)

* added a safety check to avoid unnecessary panics

* updated asciidoc

* updated asciidoc

(cherry picked from commit 4e70b69)
@ShourieG ShourieG deleted the httpjson/bugfix branch December 28, 2022 05:22
ShourieG added a commit that referenced this pull request Dec 28, 2022
@mergify @ShourieG
[filebeat][httpjson]- improved error handling during pagination with …
6ab893c 
…chaining & split processor (#34127) (#34133)

* added a safety check to avoid unnecessary panics

* updated asciidoc

* updated asciidoc

(cherry picked from commit 4e70b69)

Co-authored-by: ShourieG <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@ShourieG @chrisberkhout
[filebeat][httpjson]- improved error handling during pagination with …
79d7f55 
…chaining & split processor (#34127)

* added a safety check to avoid unnecessary panics

* updated asciidoc

* updated asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

@ShourieG ShourieG

Labels
8.7-candidate backport-v8.6.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpjson bugfix - improves error handling during pagination with chaining & split processor
3 participants
@ShourieG @elasticmachine @P1llus