Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Generate check_group for individual journeys inside zip_urls bundle #33698

Closed
emilioalvap opened this issue Nov 16, 2022 · 1 comment · Fixed by #33723
Closed

[Heartbeat] Generate check_group for individual journeys inside zip_urls bundle #33698

emilioalvap opened this issue Nov 16, 2022 · 1 comment · Fixed by #33723
Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.4.0

Comments

@emilioalvap
Copy link
Collaborator

Summary

Due to the change to stream enrichers, heartbeat is only generating a check group uuid once for each zip_url iterations, instead of once for each journey. This causes all journeys to be grouped together into a single summary.

How to reproduce

In a cluster with an enrolled agent:

  1. Create a synthetics integration of Browser type:
    • zip url: https://github.com/elastic/synthetics/archive/refs/heads/master.zip
    • folder: examples/todos
  2. Wait for the first result and check all journeys' steps are part of the same check group:
    image
@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.4.0 labels Nov 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

andrewvc added a commit to andrewvc/beats that referenced this issue Nov 18, 2022
@andrewvc
[Heartbeat] Fix zip monitors by changing the check group after summar…
efce225 
…y docs

Fixes elastic#33698
@andrewvc andrewvc mentioned this issue Nov 18, 2022
Merged
emilioalvap added a commit that referenced this issue Nov 21, 2022
@andrewvc @emilioalvap
[Heartbeat] Fix zip monitors (#33723)
453dfcb 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
mergify bot pushed a commit that referenced this issue Nov 21, 2022
@andrewvc @mergify
[Heartbeat] Fix zip monitors (#33723)
72a4651 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)
mergify bot pushed a commit that referenced this issue Nov 21, 2022
@andrewvc @mergify
[Heartbeat] Fix zip monitors (#33723)
415b0bc 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)
emilioalvap pushed a commit that referenced this issue Nov 21, 2022
@mergify @andrewvc
[Heartbeat] Fix zip monitors (#33723) (#33739)
38c0ce1 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)

Co-authored-by: Andrew Cholakian <[email protected]>
emilioalvap pushed a commit that referenced this issue Nov 21, 2022
@mergify @andrewvc
[Heartbeat] Fix zip monitors (#33723) (#33738)
b2bbbb4 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)

Co-authored-by: Andrew Cholakian <[email protected]>
chrisberkhout pushed a commit that referenced this issue Jun 1, 2023
@andrewvc @emilioalvap @chrisberkhout
[Heartbeat] Fix zip monitors (#33723)
b65ef34 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Heartbeat] Fix zip monitors andrewvc/beats
2 participants
@elasticmachine @emilioalvap