Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Fix zip monitors #33723

Merged
merged 11 commits into from
Nov 21, 2022
Merged

[Heartbeat] Fix zip monitors #33723

merged 11 commits into from
Nov 21, 2022

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Nov 18, 2022 •
edited
Loading

Fixes them by changing the check group after summar…y docs

Fixes #33698

No tests, etc. because this feature will be removed in 8.7

Tested with:

- name: TDZIP
  id: tdzip
  type: browser
  schedule: "@every 3m"
  tags: todos-app
  params:
    url: "https://elastic.github.io/synthetics-demo/"
  source:
    zip_url: 
      url: "https://github.com/elastic/synthetics-demo/archive/refs/heads/main.zip"
      folder: "todos"

Run with, from x-pack/heartbeat folder:

mage build && ELASTIC_SYNTHETICS_CAPABLE=true ./heartbeat -e -E cloud.id=$CLOUD_ID -E cloud.auth=$CLOUD_AUTH -E output.elasticsearch.allow_older_versions=true

@andrewvc andrewvc requested a review from a team as a code owner November 18, 2022 02:41
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2022
@andrewvc andrewvc self-assigned this Nov 18, 2022
@andrewvc andrewvc added Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Nov 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2022
@andrewvc andrewvc added bug needs_team Indicates that the issue/PR needs a Team:* label labels Nov 18, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 18, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewvc? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@andrewvc andrewvc added the backport-v8.6.0 Automated backport with mergify label Nov 18, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 18, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-18T21:31:28.738+0000

  • Duration: 39 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 313
Skipped 0
Total 313

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

emilioalvap
emilioalvap reviewed Nov 18, 2022
View reviewed changes
x-pack/heartbeat/monitors.d/zipurl.yml Outdated
@@ -0,0 +1,12 @@

- name: TDZIP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be commited?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, nope

emilioalvap
emilioalvap approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilioalvap emilioalvap merged commit 453dfcb into elastic:main Nov 21, 2022
@emilioalvap emilioalvap added the backport-v8.5.0 Automated backport with mergify label Nov 21, 2022
mergify bot pushed a commit that referenced this pull request Nov 21, 2022
@andrewvc @mergify
[Heartbeat] Fix zip monitors (#33723)
72a4651 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)
@mergify mergify bot mentioned this pull request Nov 21, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 21, 2022
@andrewvc @mergify
[Heartbeat] Fix zip monitors (#33723)
415b0bc 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)
@mergify mergify bot mentioned this pull request Nov 21, 2022
Merged
emilioalvap pushed a commit that referenced this pull request Nov 21, 2022
@mergify @andrewvc
[Heartbeat] Fix zip monitors (#33723) (#33739)
38c0ce1 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)

Co-authored-by: Andrew Cholakian <[email protected]>
emilioalvap pushed a commit that referenced this pull request Nov 21, 2022
@mergify @andrewvc
[Heartbeat] Fix zip monitors (#33723) (#33738)
b2bbbb4 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
(cherry picked from commit 453dfcb)

Co-authored-by: Andrew Cholakian <[email protected]>
@andrewvc andrewvc deleted the fix-zip-monitors branch December 5, 2022 21:13
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@andrewvc @emilioalvap @chrisberkhout
[Heartbeat] Fix zip monitors (#33723)
b65ef34 
* [Heartbeat] Fix zip monitors by changing the check group after summary docs

Fixes #33698

* Add null chuck

* More robust check groups

* Add nil check

* Make linter happy

* Remove accidental config

* Fix heartbeat.yml

* Update x-pack/heartbeat/monitors/browser/synthexec/enrich.go

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Add changelog

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilioalvap emilioalvap emilioalvap approved these changes

Assignees

@andrewvc andrewvc

Labels
backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Generate check_group for individual journeys inside zip_urls bundle
3 participants
@andrewvc @elasticmachine @emilioalvap