-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update target in metricbeat magefile.go to include collectDocs target #18062
Fix update target in metricbeat magefile.go to include collectDocs target #18062
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!!
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
I think there are still problems (unless we removed support for 1 - Here's git status after running
|
I checked Filebeat and confirmed that |
Seems like this commit broke the doc scripts for metricbeat: 8786d05#diff-34acb1c4bf062801dbb1a2e9554fcfaf |
…in update target.
@dedemorton Nice catch, I have updated the magefile to do the correct thing for the asciidocs on fields. I also added the |
…rget (elastic#18062) * Fix update target in metricbeat magefile.go to include collectDocs target. * Add make doc to makefile shim, use collectall instead of collectdocs in update target. (cherry picked from commit 7d16a0f)
What does this PR do?
Fixes the
mage update
target in metricbeat to also callmage collectDocs
.Why is it important?
So the
docs/
are generate for metricbeat.Checklist
[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
mage update
updates the documentation.How to test this PR locally
$ mage update
or
$ make update