Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat][Kubernetes] Add condition NetworkUnavailable to state node #34976

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[Metricbeat][Kubernetes] Add condition NetworkUnavailable to state node #34976

merged 1 commit into from
Mar 31, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Ad condition NetworkUnavailable to state node.

This was requested on this issue #34724.

@constanca-m constanca-m added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Mar 30, 2023
@constanca-m constanca-m requested a review from a team as a code owner March 30, 2023 12:26
@constanca-m constanca-m self-assigned this Mar 30, 2023
@constanca-m constanca-m requested review from ChrsMark and MichaelKatsoulis and removed request for a team March 30, 2023 12:26
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @constanca-m? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T12:26:54.677+0000

  • Duration: 82 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 4365
Skipped 882
Total 5247

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

ChrsMark
ChrsMark approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Please also remember to update the fields in the integration too:) (https://github.com/elastic/integrations/tree/main/packages/kubernetes)

@constanca-m constanca-m merged commit 6f99799 into elastic:main Mar 31, 2023
@constanca-m constanca-m deleted the add-networkunavailable branch March 31, 2023 05:19
@constanca-m constanca-m mentioned this pull request Mar 31, 2023
Merged
tetianakravchenko
tetianakravchenko reviewed Apr 3, 2023
View reviewed changes
metricbeat/module/kubernetes/state_node/state_node.go
"Ready": "ready",
"MemoryPressure": "memory_pressure",
"DiskPressure": "disk_pressure",
"OutOfDisk": "out_of_disk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this status still available? looking at https://kubernetes.io/docs/concepts/architecture/nodes/#condition - doesn't seem so

could we please adjust it as well?

Copy link
Contributor Author

@constanca-m constanca-m Apr 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which status? @tetianakravchenko

I see OutOfDisk doesn't seem available anymore, but maybe it still exists for older versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this value was deleted in K8s version 1.16 - https://github.com/kubernetes/kubernetes/blob/d89d5ab2680bc74fe4487ad71e514f4e0812d9ce/CHANGELOG/CHANGELOG-1.16.md?plain=1#L1626

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@constanca-m @chrisberkhout
Add condition (#34976)
74327f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetianakravchenko tetianakravchenko tetianakravchenko left review comments

@ChrsMark ChrsMark ChrsMark approved these changes

@gizas gizas gizas approved these changes

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis MichaelKatsoulis is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@constanca-m constanca-m

Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@constanca-m @elasticmachine @gizas @ChrsMark @tetianakravchenko