Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat][Kubernetes] Add condition NetworkUnavailable to state node #34976

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[Metricbeat][Kubernetes] Add condition NetworkUnavailable to state node #34976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions metricbeat/docs/fields.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46008,6 +46008,16 @@ type: keyword
Node PIDPressure status (true, false or unknown)


type: keyword

--

*`kubernetes.node.status.network_unavailable`*::
+
--
Node NetworkUnavailable status (true, false or unknown)


type: keyword

--
Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/kubernetes/fields.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions metricbeat/module/kubernetes/state_node/_meta/fields.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
type: keyword
description: >
Node PIDPressure status (true, false or unknown)
- name: network_unavailable
type: keyword
description: >
Node NetworkUnavailable status (true, false or unknown)
- name: cpu
type: group
fields:
Expand Down
11 changes: 6 additions & 5 deletions metricbeat/module/kubernetes/state_node/state_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,12 @@ var mapping = &p.MetricsMapping{

"kube_node_status_condition": p.LabelMetric("status", "status", p.OpFilterMap(
"condition", map[string]string{
"Ready": "ready",
"MemoryPressure": "memory_pressure",
"DiskPressure": "disk_pressure",
"OutOfDisk": "out_of_disk",
"PIDPressure": "pid_pressure",
"Ready": "ready",
"MemoryPressure": "memory_pressure",
"DiskPressure": "disk_pressure",
"OutOfDisk": "out_of_disk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this status still available? looking at https://kubernetes.io/docs/concepts/architecture/nodes/#condition - doesn't seem so

could we please adjust it as well?

Copy link
Contributor Author

@constanca-m constanca-m Apr 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which status? @tetianakravchenko

I see OutOfDisk doesn't seem available anymore, but maybe it still exists for older versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this value was deleted in K8s version 1.16 - https://github.com/kubernetes/kubernetes/blob/d89d5ab2680bc74fe4487ad71e514f4e0812d9ce/CHANGELOG/CHANGELOG-1.16.md?plain=1#L1626

"PIDPressure": "pid_pressure",
"NetworkUnavailable": "network_unavailable",
},
)),
},
Expand Down