-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.13](backport #38405) x-pack/filebeat/input/{cel,httpjson}: fix PEM key validation #38406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Mar 19, 2024
This pull request doesn't have a |
efd6
reviewed
Mar 19, 2024
efd6
force-pushed
the
mergify/bp/8.13/pr-38405
branch
from
March 19, 2024 06:48
35ee0d0
to
4c0acc0
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
efd6
reviewed
Mar 19, 2024
Previously the validation was attempting to parse the PEM text as a key and was also attempting to parse the data as the wrong kind of key. (cherry picked from commit c29075e)
efd6
force-pushed
the
mergify/bp/8.13/pr-38405
branch
from
March 19, 2024 06:51
66cca94
to
9e32b28
Compare
efd6
force-pushed
the
mergify/bp/8.13/pr-38405
branch
from
March 19, 2024 06:53
9e32b28
to
79de0b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Previously the validation was attempting to parse the PEM text as a key and was also attempting to parse the data as the wrong kind of key.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #38405 done by [Mergify](https://mergify.com).