Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

okta: allow users to provide private key as a PEM block #9291

Merged
merged 1 commit into from
Apr 1, 2024
Merged

okta: allow users to provide private key as a PEM block #9291

merged 1 commit into from
Apr 1, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 7, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Mar 7, 2024
@efd6 efd6 self-assigned this Mar 7, 2024
@efd6 efd6 mentioned this pull request Mar 19, 2024
Merged
6 tasks
@efd6 efd6 marked this pull request as ready for review March 19, 2024 02:09
@efd6 efd6 requested a review from a team as a code owner March 19, 2024 02:09
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 marked this pull request as draft March 19, 2024 02:09
@mergify mergify bot mentioned this pull request Mar 19, 2024
Merged
6 tasks
@efd6
Copy link
Contributor Author

efd6 commented Mar 26, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review March 26, 2024 09:31
@efd6 efd6 merged commit 791d380 into elastic:main Apr 1, 2024
5 checks passed
@elasticmachine
Copy link

Package okta - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=okta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:okta Okta Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Okta] Supporting credentials in PEM format
3 participants
@efd6 @elasticmachine @andrewkroh