-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Go 1.22.5 #40082
Update to Go 1.22.5 #40082
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
CI seems unable to find the |
@elastic/ingest-eng-prod can someone please assist here with the golang version update? |
Indeed, the images falls back to installing the missing go, if not prebundled in cases of PR like this one, but we also need to install |
A new Windows 2022 image got built recently (see pr). I clicked retry to the heartbeat win 2022 job which seems to be moving forwards ( |
This has been successful, so I've since rebuilt all Windows custom Beats images to support mage installation as a fallback and clicked retry on all failed jobs ^^ |
I believe that go 1.22 adjusts how its represents a regex into a string. See commit for the changes I made to the tests, I don't see any really issues with these changes in the test. 88964ad |
/test |
Note we chatted with @oakrizan about the failing x-pack/metricbeat: AWS Tests and at least as of 4 days ago they used be successful: https://buildkite.com/elastic/beats-xpack-metricbeat/builds/5078#0190a2f4-ee9d-4b99-8311-924166b10128 So it's unclear whether they are affected by this PR, or something else that's changed during the last few days. UPDATE: They aren't related to this PR; see #40242 |
Additionally there appears to be general flakiness with macOS arm64 CI tests; usually the four automatic buildkite retries help, but lately seems they don't; the issue is tracked in #40237 |
Thanks for your help and the detailed RCA, @shmsr. Back over to you @blakerouse. |
@shmsr Thank you so much for the help and detailed analysis on this issue, I really appreciate it. I have updated the PR with latest main, lets see if it fully passes. |
@pierrehilbert @cmacknz after chatting with @blakerouse we do need to backport this to 8.15 in order to align go versions in Agent and Beats. |
I'm fine to force merge this and backport to 8.15, we just need the new conflict to be resolved first. |
I have fixed the conflict, once we get green again lets force merge this. |
* Update to go 1.22.4. * Link to PR. * Fix bad merge. * Fix some regex. * Fix config_test.go * Comment out ping. * Update to go 1.22.5. * Un-comment code. * Update go.mod. * Add encrypt=false to mssql py test. * Make CI happy * Fix NOTICE.txt. --------- Co-authored-by: subham sarkar <[email protected]> Co-authored-by: Julien Lind <[email protected]> (cherry picked from commit c0f8ae3)
* Update to go 1.22.4. * Link to PR. * Fix bad merge. * Fix some regex. * Fix config_test.go * Comment out ping. * Update to go 1.22.5. * Un-comment code. * Update go.mod. * Add encrypt=false to mssql py test. * Make CI happy * Fix NOTICE.txt. --------- Co-authored-by: subham sarkar <[email protected]> Co-authored-by: Julien Lind <[email protected]> (cherry picked from commit c0f8ae3) # Conflicts: # auditbeat/module/file_integrity/config_test.go # dev-tools/mage/crossbuild.go # go.mod # libbeat/docs/version.asciidoc # libbeat/processors/actions/drop_fields_test.go # metricbeat/Dockerfile
* Update to go 1.22.4. * Link to PR. * Fix bad merge. * Fix some regex. * Fix config_test.go * Comment out ping. * Update to go 1.22.5. * Un-comment code. * Update go.mod. * Add encrypt=false to mssql py test. * Make CI happy * Fix NOTICE.txt. --------- Co-authored-by: subham sarkar <[email protected]> Co-authored-by: Julien Lind <[email protected]> (cherry picked from commit c0f8ae3) Co-authored-by: Blake Rouse <[email protected]>
* Update to Go 1.22.5 (#40082)
Proposed commit message
Update to the latest version of golang 1.22.5.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.