Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang to v1.23 #5683

Merged
merged 30 commits into from
Sep 26, 2024
Merged

bump golang to v1.23 #5683

merged 30 commits into from
Sep 26, 2024

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Jul 16, 2024

What problem does this PR solve?

ref #5682

  • Bump Golang to v1.23
  • Many updates to ensure CI can work well

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from shonge July 16, 2024 02:28
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jul 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.97%. Comparing base (9ef26f8) to head (a461577).
Report is 23 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9ef26f8) and HEAD (a461577). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ef26f8) HEAD (a461577)
unittest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5683       +/-   ##
===========================================
- Coverage   61.47%   46.97%   -14.50%     
===========================================
  Files         235      219       -16     
  Lines       30653    30697       +44     
===========================================
- Hits        18843    14420     -4423     
- Misses       9920    14571     +4651     
+ Partials     1890     1706      -184     
Flag Coverage Δ
e2e 46.97% <0.00%> (?)
unittest ?

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc csuzhangxc changed the title [WIP] bump golang to v1.22 bump golang to v1.22 Jul 16, 2024
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-tngm

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-tikv-scale-simultaneously

1 similar comment
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc csuzhangxc merged commit 776b9fb into pingcap:master Sep 26, 2024
12 of 13 checks passed
@csuzhangxc csuzhangxc deleted the go-1.22 branch September 26, 2024 03:13
@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5753.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Sep 26, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 26, 2024
10 tasks
csuzhangxc added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants