Bound random negative size test in SearchSourceBuilderTests#testNegat…

…iveSizeErrors (#88457)

-1 is handled differently by the xcontent code path so this test will fail when `randomIntBetween` lands on -1.

To fix, we add another integer for the xcontent test which starts at -2.

server/src/test/java/org/elasticsearch/search/builder/SearchSourceBuilderTests.java

@@ -500,10 +500,12 @@ public void testNegativeSizeErrors() throws IOException {
         expected = expectThrows(IllegalArgumentException.class, () -> new SearchSourceBuilder().size(-1));
         assertEquals("[size] parameter cannot be negative, found [-1]", expected.getMessage());
 
-        String restContent = "{\"size\" : " + randomSize + "}";
+        // SearchSourceBuilder.fromXContent treats -1 as not-set
+        int boundedRandomSize = randomIntBetween(-100000, -2);
+        String restContent = "{\"size\" : " + boundedRandomSize + "}";
         try (XContentParser parser = createParser(JsonXContent.jsonXContent, restContent)) {
             IllegalArgumentException ex = expectThrows(IllegalArgumentException.class, () -> SearchSourceBuilder.fromXContent(parser));
-            assertThat(ex.getMessage(), containsString(Integer.toString(randomSize)));
+            assertThat(ex.getMessage(), containsString(Integer.toString(boundedRandomSize)));
         }
 
         restContent = "{\"size\" : -1}";