Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SearchSourceBuilderTests testNegativeSizeErrors] Bound random negative size test #88457

Conversation

matschaffer
Copy link
Contributor

-1 is handled differently by the xcontent code path so this test will fail when randomIntBetween lands on -1.

To fix, we add another integer for the xcontent test which starts at -2.

Fixes #88423

-1 is handled differently by the xcontent code path so this test will fail when `randomIntBetween` lands on -1.

To fix, we add another integer for the xcontent test which starts at -2.
@matschaffer matschaffer self-assigned this Jul 12, 2022
@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.4.0 labels Jul 12, 2022
@matschaffer matschaffer added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels Jul 12, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@matschaffer
Copy link
Contributor Author

I had no idea what team :Team to assign, so I just used the most recent PR to the same file. Feel free to re-route if appropriate.

@DaveCTurner DaveCTurner added :Search/Search Search-related issues that do not fall into other categories and removed :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team Team:Infra Monitoring UI labels Jul 12, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jul 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@DaveCTurner DaveCTurner removed their request for review July 12, 2022 07:11
@DaveCTurner
Copy link
Contributor

Thanks Mat, I have rerouted to the search team and will let Christoph and colleagues think about the details (including potentially backporting it).

@javanna javanna removed the request for review from cbuescher July 12, 2022 12:13
@javanna javanna removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jul 12, 2022
@javanna javanna self-assigned this Jul 12, 2022
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@javanna javanna added auto-backport Automatically create backport pull requests when merged v8.3.3 labels Jul 12, 2022
@javanna javanna merged commit 5628b87 into elastic:master Jul 12, 2022
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.3

matschaffer added a commit to matschaffer/elasticsearch that referenced this pull request Jul 12, 2022
…iveSizeErrors (elastic#88457)

-1 is handled differently by the xcontent code path so this test will fail when `randomIntBetween` lands on -1.

To fix, we add another integer for the xcontent test which starts at -2.
@matschaffer matschaffer deleted the elasticsearch-88423-test-negative-size-flake branch July 12, 2022 13:00
javanna pushed a commit that referenced this pull request Jul 12, 2022
…iveSizeErrors (#88457)

-1 is handled differently by the xcontent code path so this test will fail when `randomIntBetween` lands on -1.

To fix, we add another integer for the xcontent test which starts at -2.
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 13, 2022
* upstream/master: (38 commits)
  Simplify map copying (elastic#88432)
  Make DiffableUtils.diff implementation agnostic (elastic#88403)
  Ingest: Start separating Metadata from IngestSourceAndMetadata (elastic#88401)
  Move runtime fields base scripts out of scripting fields api package. (elastic#88488)
  Enable TRACE Logging for test and increase timeout (elastic#88477)
  Mute ReactiveStorageIT#testScaleDuringSplitOrClone (elastic#88480)
  Track the count of failed invocations since last successful policy snapshot (elastic#88398)
  Avoid noisy exceptions on data nodes when aborting snapshots (elastic#88476)
  Fix ReactiveStorageDeciderServiceTests testNodeSizeForDataBelowLowWatermark (elastic#88452)
  INFO logging of snapshot restore and completion (elastic#88257)
  unmute test (elastic#88454)
  Updatable API keys - noop check (elastic#88346)
  Corrected an incomplete sentence. (elastic#86542)
  Use consistent shard map type in IndexService (elastic#88465)
  Stop registering TestGeoShapeFieldMapperPlugin in ESIntegTestCase (elastic#88460)
  TSDB: RollupShardIndexer logging improvements (elastic#88416)
  Audit API key ID when create or grant API keys (elastic#88456)
  Bound random negative size test in SearchSourceBuilderTests#testNegativeSizeErrors (elastic#88457)
  Updatable API keys - logging audit trail event (elastic#88276)
  Polish reworked LoggedExec task (elastic#88424)
  ...

# Conflicts:
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/RollupShardIndexer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test-failure Triaged test failures from CI v8.3.3 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SearchSourceBuilderTests testNegativeSizeErrors failing
5 participants