Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping deprecations warnings in logs but not in warning headers #23947

Closed
cbuescher opened this issue Apr 6, 2017 · 3 comments
Closed

Mapping deprecations warnings in logs but not in warning headers #23947

cbuescher opened this issue Apr 6, 2017 · 3 comments
Assignees
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v5.3.0

Comments

@cbuescher
Copy link
Member

Not sure this is a bug, but I'm looking at deprecation warnings when creating new indices (settings, mappings). When I use the following in Console:

PUT /test
{
  "settings": {
    "number_of_shards": 1,
    "shadow_replicas": true,
    "shared_filesystem": false
  },
  "mappings": {
    "type": {
      "properties": {
        "field": {
          "type": "string"
        },
        "field2": {
          "type": "long",
          "store" : "no"
        }
      }
    }
  }
}

I see the following in elasticsearch_deprecation.log:

[2017-04-06T17:05:36,473][WARN ][o.e.d.c.s.Setting        ] [index.shadow_replicas] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.
[2017-04-06T17:05:36,481][WARN ][o.e.d.c.s.Setting        ] [index.shared_filesystem] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.
[2017-04-06T17:05:36,481][WARN ][o.e.d.c.s.Setting        ] [index.shadow_replicas] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.
[2017-04-06T17:05:36,487][WARN ][o.e.d.i.m.StringFieldMapper$TypeParser] The [string] field is deprecated, please use [text] or [keyword] instead on [field]
[2017-04-06T17:05:36,488][WARN ][o.e.d.c.x.s.XContentMapValues] Expected a boolean [true/false] for property [field2.store] but got [no]

But I only get the following deprecation warnings in the warning headers (in Console):

#! Deprecation: [index.shadow_replicas] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.
#! Deprecation: [index.shared_filesystem] setting was deprecated in Elasticsearch and will be removed in a future release! See the breaking changes documentation for the next major version.

I also checked the same with curl, I also get only the two setting warning headers there:

curl -H "Content-Type: application/json" -XPUT localhost:9200/test -d '{
  "settings": {
    "number_of_shards" : 1,
    "shadow_replicas": true,
    "shared_filesystem": false
  },
  "mappings": {
    "type": {
        "properties": {
            "field" : { "type" : "long", "store" : "no" },
            "field2" : { "type":"string"}
        }
    }
  }
}' -i

Am I missing something?

Elasticsearch version: 5.3.0

Plugins installed: []

JVM version: 1.8.0_121

@cbuescher cbuescher added :Search Foundations/Mapping Index mappings, including merging and defining field types :Core/Infra/Settings Settings infrastructure and APIs >bug v5.3.0 labels Apr 6, 2017
@javanna javanna added the help wanted adoptme label Apr 6, 2017
@javanna
Copy link
Member

javanna commented Apr 6, 2017

I don't think you are missing anything, I can reproduce and I'd expect those two warnings to be returned as a Warning header, but they are not.

@jasontedor
Copy link
Member

This looks bad. It appears to have something to do with the mapping update happening on the cluster state update task thread. I'm discussing this one with @jaymode now.

@jasontedor jasontedor removed the help wanted adoptme label Apr 6, 2017
jaymode added a commit to jaymode/elasticsearch that referenced this issue Apr 6, 2017
This commit preserves the response headers when creating an index and updating settings for an
index.

Closes elastic#23947
jaymode added a commit that referenced this issue Apr 6, 2017
This commit preserves the response headers when creating an index and updating settings for an
index.

Closes #23947
jaymode added a commit that referenced this issue Apr 6, 2017
This commit preserves the response headers when creating an index and updating settings for an
index.

Closes #23947
jaymode added a commit that referenced this issue Apr 6, 2017
This commit preserves the response headers when creating an index and updating settings for an
index.

Closes #23947
@jaymode
Copy link
Member

jaymode commented Apr 6, 2017

Good find @cbuescher

@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v5.3.0
Projects
None yet
Development

No branches or pull requests

4 participants