Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve response headers when creating an index #23950

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Apr 6, 2017

This commit preserves the response headers when creating an index and updating settings for an
index.

Closes #23947

This commit preserves the response headers when creating an index and updating settings for an
index.

Closes elastic#23947
@jaymode jaymode added :Search Foundations/Mapping Index mappings, including merging and defining field types :Core/Infra/Settings Settings infrastructure and APIs >bug review v5.3.1 v5.4.0 v6.0.0-alpha1 labels Apr 6, 2017
@jaymode jaymode requested a review from jasontedor April 6, 2017 17:28
@jaymode
Copy link
Member Author

jaymode commented Apr 6, 2017

The rest test will need to be changed on backport so it is not skipped but it is in here so it can be reviewed.

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jaymode jaymode merged commit 495bf21 into elastic:master Apr 6, 2017
jaymode added a commit that referenced this pull request Apr 6, 2017
This commit preserves the response headers when creating an index and updating settings for an
index.

Closes #23947
jaymode added a commit that referenced this pull request Apr 6, 2017
This commit preserves the response headers when creating an index and updating settings for an
index.

Closes #23947
jaymode added a commit that referenced this pull request Apr 6, 2017
This test was added in #23950 for backporting and review, but it is always skipped on master so
this commit deletes it.
@jaymode jaymode deleted the create_index_warnings branch April 6, 2017 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs :Search Foundations/Mapping Index mappings, including merging and defining field types v5.3.1 v5.4.0 v6.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants