Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] UnusedStateRemover will remove all state for jobs not in cluster state #37109

Closed
droberts195 opened this issue Jan 3, 2019 · 1 comment
Assignees
Labels

Comments

@droberts195
Copy link
Contributor

The UnusedStateRemover only checks which jobs exist by looking in the cluster state. It deletes state documents that do not correspond to a job that exists. Therefore, following the move to storing job configurations in an index it will delete all model state for such jobs each night, leaving them unable to be reopened if they are closed before another background persist is performed.

The UnusedStateRemover needs to be changed to consider jobs in both cluster state and indices. (This basically means it should get the jobs list via the job manager - the problem is very similar to the one fixed in #36936.)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@dimitris-athanasiou dimitris-athanasiou self-assigned this Jan 3, 2019
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Jan 3, 2019
The unused state remover was never adjusted to account for jobs stored
in the config index. The result was that when triggered it removed
state for all jobs stored in the config index.
This commit fixes the issue.

Closes elastic#37109
dimitris-athanasiou added a commit that referenced this issue Jan 4, 2019
The unused state remover was never adjusted to account for jobs stored
in the config index. The result was that when triggered it removed
state for all jobs stored in the config index.
This commit fixes the issue.

Closes #37109
dimitris-athanasiou added a commit that referenced this issue Jan 4, 2019
The unused state remover was never adjusted to account for jobs stored
in the config index. The result was that when triggered it removed
state for all jobs stored in the config index.
This commit fixes the issue.

Closes #37109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants