[ML] Unused state remover should also account for jobs in index #37119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unused state remover was never adjusted to account for jobs stored in the config index. The result was that when triggered it removed state for all jobs stored in the config index. This commit fixes the issue. Closes elastic#37109
|
Pinging @elastic/ml-core |
droberts195
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
LGTM
I know we originally discussed removing the cluster state bit from 7.x, but it shouldn't hurt to leave in 7.x and doing this would avoid a race condition where a full cluster restart upgrade from 6.x is done at the exact moment the nightly maintenance check happens. So it's probably best to forward port to master as-is, then the cluster state bit will eventually get removed when master is for 8.x.
|
Sounds good. I'll add a TODO. |
|
jenkins please test this |
1 similar comment
|
jenkins please test this |
|
run gradle build tests 1 |
dimitris-athanasiou
deleted the
unused-state-remover-should-also-account-for-jobs-in-index
branch
dimitris-athanasiou
added a commit
that referenced
this pull request
Jan 4, 2019
The unused state remover was never adjusted to account for jobs stored in the config index. The result was that when triggered it removed state for all jobs stored in the config index. This commit fixes the issue. Closes #37109
dimitris-athanasiou
added a commit
that referenced
this pull request
Jan 4, 2019
The unused state remover was never adjusted to account for jobs stored in the config index. The result was that when triggered it removed state for all jobs stored in the config index. This commit fixes the issue. Closes #37109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unused state remover was never adjusted to account for jobs stored
in the config index. The result was that when triggered it removed
state for all jobs stored in the config index.
This commit fixes the issue.
Closes #37109