Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor classes like RestIntegTestTask that do extended configuration in the constructor. #47804

Closed
alpar-t opened this issue Oct 9, 2019 · 3 comments
Closed

Refactor classes like RestIntegTestTask that do extended configuration in the constructor. #47804

alpar-t opened this issue Oct 9, 2019 · 3 comments
Assignees
@alpar-t
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@alpar-t
Copy link
Contributor

alpar-t commented Oct 9, 2019

These tasks make configuration hard to follow.

We would like to replace their use with a plugin that sets up the task and necessary configuration for these types of tests.
@alpar-t alpar-t added the :Delivery/Build Build or test infrastructure label Oct 9, 2019
@alpar-t alpar-t self-assigned this Oct 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@mark-vieira mark-vieira mentioned this issue Feb 3, 2020
Closed
@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@mark-vieira mark-vieira mentioned this issue May 18, 2020
Merged
@breskeby
Copy link
Contributor

I've tackled this one in #60261

jakelandis added a commit that referenced this issue Sep 18, 2020
@jakelandis
Make yamlRestTest and javaRestTest tasks lazy (#62515)
0369def 
This commit changes the yamlRestTest and javaRestTest tasks to be lazily created.
This change requires pro-actively creating the testClusters container so that the
configuration can be applied without any changes to the build.gradle files.

related: #60261
related: #47804
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Sep 18, 2020
@jakelandis
Make yamlRestTest and javaRestTest tasks lazy (elastic#62515)
54c28c5 
This commit changes the yamlRestTest and javaRestTest tasks to be lazily created.
This change requires pro-actively creating the testClusters container so that the
configuration can be applied without any changes to the build.gradle files.

related: elastic#60261
related: elastic#47804
jakelandis added a commit that referenced this issue Sep 18, 2020
@jakelandis
[7.x] Make yamlRestTest and javaRestTest tasks lazy (#62515) (#62632)
392f99d 
This commit changes the yamlRestTest and javaRestTest tasks to be lazily created.
This change requires pro-actively creating the testClusters container so that the
configuration can be applied without any changes to the build.gradle files.

related: #60261
related: #47804
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
@mark-vieira
Copy link
Contributor

As part of refactoring to support things like lazy task evaluation and the configuration cache we no longer perform logic in task constructors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alpar-t alpar-t

Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@breskeby @rjernst @alpar-t @mark-vieira @elasticmachine