Merge test runner task into RestIntegTest #60261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
breskeby
force-pushed
the
task-avoidance-friendly-rest-integtests
branch
from
8ef064b
to
f41c2a5
Compare
breskeby
force-pushed
the
task-avoidance-friendly-rest-integtests
branch
from
f41c2a5
to
db0eb83
Compare
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
mark-vieira
approved these changes
Jul 31, 2020
| @@ -67,6 +67,8 @@ class StandaloneRestTestPlugin implements Plugin<Project> { | |||
| ElasticsearchJavaPlugin.configureInputNormalization(project) | |||
| ElasticsearchJavaPlugin.configureCompile(project) | |||
|
|
|||
| project.pluginManager.apply(RestTestBasePlugin) | |||
There was a problem hiding this comment.
nit: can we group this up above with the other plugin applications?
There was a problem hiding this comment.
the original reason for this was that the plugin relies on nonInputSystemProperties.
I've redid the general augmentation of Test tasks now and moved that into its own plugin. Another benefit of this is we removed one reused static method from ElasticsearchJavaPlugin.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 3, 2020
* Merge test runner task into RestIntegTest * Reorganizing Standalone runner and RestIntegTest task * Rework general test task configuration and extension
breskeby
added a commit
that referenced
this pull request
Aug 4, 2020
* Merge test runner task into RestIntegTest (#60261) * Merge test runner task into RestIntegTest * Reorganizing Standalone runner and RestIntegTest task * Rework general test task configuration and extension * Fix merge issues * use former 7.x common test configuration
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Sep 18, 2020
This commit changes the yamlRestTest and javaRestTest tasks to be lazily created. This change requires pro-actively creating the testClusters container so that the configuration can be applied without any changes to the build.gradle files. related: elastic#60261 related: elastic#47804
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestIntegTestRestTestRunnerTaskand renamed toStandaloneRestIntegTestfor standalone usages of the runner task without configuration conventions applied.RestIntegTest